From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D047E242D7B for ; Tue, 14 Apr 2026 17:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776186216; cv=none; b=l1fZmGgxMwTkV0GYjeVUOiq8QdXC6cYFFP80wygH+2j8XZpA4l6EIqOZVHSirqIGOcV7tJLFAEAZU9ykWknDKTjktJGCG7P/7BnhNlMrdoIDdbGsrYQYTMqQemjRuQKE2riFoLOrJsFHbtIo3JP5OVe5/NHtlcHocJRDPjVyUaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776186216; c=relaxed/simple; bh=VVrpcdkZQkRWLJAoC2Fqi/ptL/mp1QBM/Qmmva793CA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bns5UbWGi6or+4tJAuxwrpOchjuivct4DHBpw6KsfqA9vpuAag6y1llY0/nGcSEOAdFwhdeLgamreCIkBxXbkuWhBTqciQ3POvMDINcPF0fDkS0JXjb+8T1/+ytxiuxb4anqKKxtgLeGh0mWA+2E8wLhqjQpkl0lDRm5ds+wG1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=llnKgIy+; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="llnKgIy+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776186215; x=1807722215; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VVrpcdkZQkRWLJAoC2Fqi/ptL/mp1QBM/Qmmva793CA=; b=llnKgIy+55fZ7nlpZlMnP5oD8AuvWQt3DaCoQ57DwsUwPTXWAzoZMGYq FRLJh6KP6szKtwPI+6iPiYi0YYB5dt9JNWQPWvKI9eWyfnM99mMAnlnS/ VMmSGCzsVmXNVb1mqQab9QZVinqMDVGFWsBh9Ssw5ET3j6pXJl8gVkn2E KOUluyO7mL2g5BcHOq8ahdw1MywoO5fP/YQQNl2Dz+RLKkQvI4Ma9DBa/ ZO01oZ5yvBVt3iaeRRJf4KoGKEY78lArJxn993upbKGZzvLfrV2GV+O6o dD+LgYTTl8H5OMOMiyCr3qzvaSbZnth4EwVvbhN9/wNeWlAJfGwuYyBO2 g==; X-CSE-ConnectionGUID: 8nnsJJxmTFq+oPh1Gar7+A== X-CSE-MsgGUID: LJYn/AxiRIWTAp7/JAH1Bw== X-IronPort-AV: E=McAfee;i="6800,10657,11759"; a="88532221" X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="88532221" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2026 10:03:30 -0700 X-CSE-ConnectionGUID: giJxleKUS3ih+I48wVgs0w== X-CSE-MsgGUID: enwJUzcUSKm0ZIFpfE+k0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="235107593" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.247]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2026 10:03:27 -0700 Date: Tue, 14 Apr 2026 20:03:24 +0300 From: Andy Shevchenko To: Joshua Crofts Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] iio: frequency: ad9832: remove kernel.h proxy header. Message-ID: References: <20260411123512.84739-1-joshua.crofts1@gmail.com> <20260411123512.84739-2-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Apr 14, 2026 at 03:27:39PM +0200, Joshua Crofts wrote: > On Tue, 14 Apr 2026 at 13:43, Andy Shevchenko > wrote: > > Please, avoid following the suggestions blindly. This work needs a careful > > check of what's exactly is being used and which header should provide the > > necessary information. While it may compile it might be still wrong. You > > need to (briefly) read the code in full. I don't use iwyu tool with tweaks > > by Jonathan Cameron, old school guy, but you can also try it [1]. > > Don't worry, I wasn't blindly following your suggestions. After some tweaking, > IWYU recommends keeping device.h and removing slab.h. My question is > whether the swap from asm/div64.h to linux/math64.h is valid? The asm > implementation would be platform specific, so swapping to math64 seems > like a good idea. Up to you, but that would need to be a separate patch, because it does the opposite to what your patch is doing. And justification is most likely that it's preferred to use linux/ generic over asm/ in the drivers. Or something in those lines... -- With Best Regards, Andy Shevchenko