From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] iio: frequency: ad9832: remove kernel.h proxy header.
Date: Wed, 15 Apr 2026 11:56:47 +0300 [thread overview]
Message-ID: <ad9SzwJDwRNldv_z@ashevche-desk.local> (raw)
In-Reply-To: <20260415080812.1284-2-joshua.crofts1@gmail.com>
On Wed, Apr 15, 2026 at 08:08:11AM +0000, Joshua Crofts wrote:
Drop the period at the end of Subject.
> Remove kernel.h proxy header and add bitops.h for
> better dependency control and code clarity. Also
> removed slab.h and moved asm header below generic
> linux headers.
I wonder if we need to elaborate a bit on 'linux' word as usually we refer to
the project as Linux. Maybe write it as '<linux/*>' (without quotes)?
> Checked with IWYU.
We have a (recently new) tag: Assisted-by or so. Can we use it here?
Otherwise LGTM, so after addressing the above:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-15 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 8:08 [PATCH v4 0/2] iio: frequency: ad9832: cleanups Joshua Crofts
2026-04-15 8:08 ` [PATCH v4 1/2] iio: frequency: ad9832: remove kernel.h proxy header Joshua Crofts
2026-04-15 8:56 ` Andy Shevchenko [this message]
2026-04-15 9:07 ` Joshua Crofts
2026-04-15 9:53 ` Joshua Crofts
2026-04-15 10:07 ` Andy Shevchenko
2026-04-15 10:08 ` Andy Shevchenko
2026-04-15 10:17 ` Joshua Crofts
2026-04-15 10:21 ` Andy Shevchenko
2026-04-15 10:32 ` Joshua Crofts
2026-04-15 8:08 ` [PATCH v4 2/2] iio: frequency: ad9832: simplify bitwise math Joshua Crofts
2026-04-15 8:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad9SzwJDwRNldv_z@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox