From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, andy@kernel.org,
gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com,
grondon@gmail.com, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: media: atomisp: cleanup parenthesis alignment in pci.
Date: Mon, 6 Apr 2026 22:41:06 +0300 [thread overview]
Message-ID: <adQMUrq7LlR2qAdF@ashevche-desk.local> (raw)
In-Reply-To: <20260405143910.10517-1-joshua.crofts1@gmail.com>
On Sun, Apr 05, 2026 at 04:39:11PM +0200, Joshua Crofts wrote:
> Cleanup parenthesis alignment as per checkpatch.pl in the
> pci/ directory.
Thanks for doing this. However, the proper fix should be the getting rid of
copy_from_compatible() in favour of using iov_iter. You can consult with
this example:
49aa6ed94c5e ("ALSA: korg1212: Convert to generic PCM copy ops")
The current patch in its form is quite low priority and not guaranteed to be
ever applied. Sorry, we consider real patches to be done first, see above.
(Note, the rest of the patch is okay, but again, quite low priority.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-06 19:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 9:18 [PATCH] staging: atomisp: fix alignment in function signature Joshua Crofts
2026-04-02 12:50 ` Andy Shevchenko
2026-04-02 12:56 ` Joshua Crofts
2026-04-02 13:03 ` Andy Shevchenko
2026-04-02 14:16 ` Joshua Crofts
2026-04-03 20:21 ` [PATCH v2] staging: atomisp: cleanup parenthesis alignment in pci Joshua Crofts
2026-04-04 19:48 ` Andy Shevchenko
2026-04-05 14:39 ` [PATCH v3] staging: media: " Joshua Crofts
2026-04-06 19:41 ` Andy Shevchenko [this message]
2026-04-07 6:32 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adQMUrq7LlR2qAdF@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=grondon@gmail.com \
--cc=hansg@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox