public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chethan C <mail.chethanc@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Petr Mladek <pmladek@suse.com>, Kees Cook <kees@kernel.org>,
	Hans Verkuil <hverkuil+cisco@kernel.org>,
	Osama Albahrani <osalbahr@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] staging: media: av7110: fix coding style
Date: Wed, 8 Apr 2026 14:25:39 +0300	[thread overview]
Message-ID: <adY7MwE5dorn9FlT@ashevche-desk.local> (raw)
In-Reply-To: <CAGhNHKgiMQ1Km-JZKQTfkw6aXh-KDKM3gjKyNiyhRwQRvyptPA@mail.gmail.com>

On Wed, Apr 08, 2026 at 10:33:28AM +0530, Chethan C wrote:
> Hi,
> 
> Just a gentle ping on this patch.
> 
> I wanted to check if there are any comments or changes needed from my side.
> 
> Thanks for your time.

You need to:
- do not top-post!
- do not quote hundreds of lines just for this message!
- wait a bit more, we are almost at the merge window time, quite unlikely
somebody will take this right away
- the Subject should have "staging:" part to be dropped; all media patches
are started with "media: " even for the staging folder

Also note the formatting patches are lowest in the priority.
If you wish to provide a real contribution, try something else. For example,
one of the listed in [1]. It's not that your patch is bad or unwelcome, no,
this is about the change that does almost nothing to the driver that needs
more real work.

> On Sat, Mar 28, 2026 at 10:21 PM Chethan C <mail.chethanc@gmail.com> wrote:

> > Fix indentation and alignment issues reported by checkpatch.pl.
> >
> > Rename enums av7110_rec_play_state, av7110_type_rec_play_format,
> > and av7110_encoder_command to follow kernel naming style.
> >
> > Rename wssData and wssMode to wss_data and wss_mode to avoid
> > camelCase identifiers.

[1]: https://gist.github.com/andy-shev/a2cb1ee4767d6d2f5d20db53ecb9aabc

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-04-08 11:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 16:50 [PATCH v7] staging: media: av7110: fix coding style Chethan C
     [not found] ` <CAGhNHKgiMQ1Km-JZKQTfkw6aXh-KDKM3gjKyNiyhRwQRvyptPA@mail.gmail.com>
2026-04-08 11:25   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adY7MwE5dorn9FlT@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=kees@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mail.chethanc@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=osalbahr@gmail.com \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox