Re: [PATCH v2] staging: media: atomisp: pci: cleanup and refactor tracing functions

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Sat, Apr 04, 2026 at 10:35:47PM +0200, Daniil Bulgar wrote:
> The current tracing in sh_css.c contains many ftrace-like enter/leave
> logs that clutter the code and provide little diagnostic value. These
> manual traces are redundant because the kernel's ftrace infrastructure
> (specifically function_graph) already provides entry/exit information
> automatically.
> 
> This patch removes these redundant traces and updates the remaining
> useful logs to use __func__ instead of hardcoded function names for
> better maintainability and adherence to Linux kernel coding style.

I agree in principal of dropping enter/exit cases as it's indeed repeats
ftrace, but the problem here is that the current mechanism is not ftrace,
it's custom. And now some messages need to be retrieved via different
mechanism.  This will include time synchronisation between two records.

I suggest to move everything to trace points and trace events.

Also the change doesn't improve the style for __func__. In the formatting
string there are few different styles are in use. Converting to trace
points and trace events will also target this issue (as you simply drop
it for good, trace framework has that information already).

P.S. No need to convert all at once. Just start with one family of the events
and enable them, for (hypothetical) example, accessing HW. Then extend it
little-by-little to cover other aspects and eventually kill the full _dtrace()
custom mechanism. This better to be done in the series, so we don't have
dangling old messages after the conversion.

-- 
With Best Regards,
Andy Shevchenko