From: Dan Carpenter <error27@gmail.com>
To: Dalvin-Ehinoma Noah Aiguobas <pharcodra@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses
Date: Sat, 25 Mar 2023 10:27:52 +0300 [thread overview]
Message-ID: <addce339-7653-405b-8d1d-ef29da74a8f3@kili.mountain> (raw)
In-Reply-To: <20230325002225.GA109622@koolguy>
The subject has an extra : after the "[PATCH]:".
On Sat, Mar 25, 2023 at 01:22:25AM +0100, Dalvin-Ehinoma Noah Aiguobas wrote:
> Clean up Checkpatch issues by removing unnecessary Parentheses.
>
Just ignore checkpatch on this. Greg likes parentheses.
> @@ -478,7 +478,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
>
> result = prism2_domibset_uint32(wlandev,
> DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
> - sme->key_idx);
> + sme->key_idx);
Don't mix unrelated changes into the patch.
regards,
dan carpenter
prev parent reply other threads:[~2023-03-25 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 0:22 [PATCH]: staging: wlan-ng: Remove unnecessary Parentheses Dalvin-Ehinoma Noah Aiguobas
2023-03-25 7:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=addce339-7653-405b-8d1d-ef29da74a8f3@kili.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pharcodra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox