From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Joshua Crofts <joshua.crofts1@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] iio: frequency: ad983x: replace do_div() with div64_ul().
Date: Thu, 9 Apr 2026 18:50:24 +0300 [thread overview]
Message-ID: <adfKwP1OF1sn7Gem@ashevche-desk.local> (raw)
In-Reply-To: <b37516b6-da77-4496-8514-b14ed0ad76d1@baylibre.com>
On Thu, Apr 09, 2026 at 10:39:07AM -0500, David Lechner wrote:
> On 4/9/26 10:01 AM, Joshua Crofts wrote:
> > Coccinelle reported the following in both ad983x drivers:
> > do_div() does a 64-by-32 division, please consider using
> > div64_ul instead.
> >
> > Fix this by replacing do_div() with div64_ul(), which
> > safely handles 64-bit dividends and unsigned long
> > divisors across all architectures.
> >
> > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> > ---
> > v2:
>
> Please don't send v2 or later revisions in reply to v1. It breaks
> some workflows. Start a new thread instead.
> > - resent email with corrected addresses
>
> Instead of a v2, you can just add a RESEND prefix to the subject line
> in cases like this. But do include an explanation like this when you
> do that.
Nevertheless my comments still applicable to v2. The also Documented
recommendation to avoid sending new versions earlier than 24h.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-09 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:18 [PATCH] iio: frequency: ad983x: replace do_div() with div64_ul() Joshua Crofts
2026-04-09 13:34 ` Joshua Crofts
2026-04-09 14:52 ` Greg KH
2026-04-09 15:01 ` [PATCH v2] " Joshua Crofts
2026-04-09 15:39 ` David Lechner
2026-04-09 15:50 ` Andy Shevchenko [this message]
2026-04-09 15:49 ` [PATCH] " Andy Shevchenko
2026-04-09 17:27 ` David Laight
2026-04-09 19:58 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adfKwP1OF1sn7Gem@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox