From: Dan Carpenter <error27@gmail.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] greybus: audio: extract topology size retrieval into a helper
Date: Mon, 13 Apr 2026 10:04:46 +0300 [thread overview]
Message-ID: <adyVjoDaJoWqd-OV@stanley.mountain> (raw)
In-Reply-To: <20260411182055.24413-1-dennylin0707@gmail.com>
On Sat, Apr 11, 2026 at 06:20:55PM +0000, Hungyu Lin wrote:
> The topology retrieval code currently mixes the size query with
> allocation and data fetch in a single function.
>
> Extract the size query into a helper to make the control flow clearer.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/staging/greybus/audio_gb.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
I don't see how this is a cleanup at all...
If you were the maintainer of the code, then you could do whatever
you want, but this is your first kernel patch.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-13 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 18:20 [PATCH] greybus: audio: extract topology size retrieval into a helper Hungyu Lin
2026-04-13 7:04 ` Dan Carpenter [this message]
2026-04-13 7:16 ` Denny Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adyVjoDaJoWqd-OV@stanley.mountain \
--to=error27@gmail.com \
--cc=dennylin0707@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox