From: Dan Carpenter <error27@gmail.com>
To: Alexandru Hossu <hossu.alexandru@gmail.com>
Cc: linux-tegra@vger.kernel.org, marvin24@gmx.de,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] staging: nvec: fix pm_power_off teardown in tegra_nvec_remove()
Date: Mon, 13 Apr 2026 13:39:54 +0300 [thread overview]
Message-ID: <adzH-qGdFttuP7uq@stanley.mountain> (raw)
In-Reply-To: <adzEgwPBTTFVKBdS@stanley.mountain>
I haven't looked at if you can actually power off a system while an rmmod
is in progress... I feel like a real old grandpa when I say things like,
"Back in my day you weren't supposed to call rmmod on a production
system, the rmmod feature was only for debugging."
But the bigger picture is that linux power off is a mess. There are a
dozen different ways to power off a system. Here we have a driver
which just takes over the power off process by assigning a function
pointer. Shouldn't we instead have a list of ways to shut down the
system and have a standard way to pick which is the correct one?
Instead of worrying too much about this one driver it would be better
focus on the larger picture.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-13 10:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260412205057.386856-4-hossu.alexandru@gmail.com>
2026-04-13 10:02 ` [PATCH 4/5] staging: nvec: fix pm_power_off teardown in tegra_nvec_remove() Alexandru Hossu
2026-04-13 10:25 ` Dan Carpenter
2026-04-13 10:39 ` Dan Carpenter [this message]
2026-04-13 15:14 ` [PATCH 4/5] staging: nvec: fix unconditional pm_power_off teardown Alexandru Hossu
2026-04-12 20:51 [PATCH 3/5] staging: nvec: fix use-after-free in nvec_rx_completed() Alexandru Hossu
2026-04-12 20:51 ` [PATCH 4/5] staging: nvec: fix pm_power_off teardown in tegra_nvec_remove() Alexandru Hossu
2026-04-13 8:21 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adzH-qGdFttuP7uq@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hossu.alexandru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox