From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81D1E3BBD4 for ; Wed, 20 Mar 2024 08:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710924677; cv=none; b=cyR8vk1Bo3cvNtkPtzKHVZ6TzuAMeHTuOm/HqSCzMUijJfLsq6oxcUu2NRtcCBGsza7xsTqnjceKhzT/i7FIs75KiBmd4zqBwhDhCoqNWYqP1z7pEIPbVB4u6x7vHqnZNRTG2N2IKXGUyuRQLBnuGaqZs7zJxfmJmjVzuL9v4D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710924677; c=relaxed/simple; bh=rF0HbmXvJ06Y32Fy92o/NIU+8UdxwYrzONkezOT76qk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YFpZvD9KfXM4rz48PkS057ln2wT0NSKhOjm2GyMd66cu3W7W4+Uy9qI7EM4K2lXuFRXL9XtOEepDR/os6nLCA0g055tdr15LjXPwvp5tAZJST0y9wQY/1OpjIpPixeeFGycw/dEQJX2d6zzvUZO4aLVWKt/UPp79LUZDEIB5mOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1ydJY3KY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UWgIELCt; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1ydJY3KY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UWgIELCt; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1ydJY3KY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UWgIELCt"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1ydJY3KY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UWgIELCt" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 108A834020; Wed, 20 Mar 2024 08:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710924668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Iej1NyZKIT/SwcpbI2fMLfxfkoKNYFAwt1l2JSYzYfw=; b=1ydJY3KY0p5jS8f3i3FLw0r9VeNZnpTsRvKHqPaVoKEU8zttVR93E/z8nI/xygQCqL8HKl FXBEsewnemHFDoL8Hwqet9x25szdMzRfUQlWjJCF9qcsUk/xU3dE3tX0o8jwL+OOswhrXA Am0SZPp9mAJOYcf9o1nnBViz+Sm65ek= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710924668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Iej1NyZKIT/SwcpbI2fMLfxfkoKNYFAwt1l2JSYzYfw=; b=UWgIELCtP0zAaEbbzNcIexByZIUe1OQUFors0i87byKyrXEewovuSoJc2xdF7Ewr7xYnh/ k7Xc001IzCdQMiDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710924668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Iej1NyZKIT/SwcpbI2fMLfxfkoKNYFAwt1l2JSYzYfw=; b=1ydJY3KY0p5jS8f3i3FLw0r9VeNZnpTsRvKHqPaVoKEU8zttVR93E/z8nI/xygQCqL8HKl FXBEsewnemHFDoL8Hwqet9x25szdMzRfUQlWjJCF9qcsUk/xU3dE3tX0o8jwL+OOswhrXA Am0SZPp9mAJOYcf9o1nnBViz+Sm65ek= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710924668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Iej1NyZKIT/SwcpbI2fMLfxfkoKNYFAwt1l2JSYzYfw=; b=UWgIELCtP0zAaEbbzNcIexByZIUe1OQUFors0i87byKyrXEewovuSoJc2xdF7Ewr7xYnh/ k7Xc001IzCdQMiDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 987A8136CD; Wed, 20 Mar 2024 08:51:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id C8qXInuj+mU+SAAAD6G6ig (envelope-from ); Wed, 20 Mar 2024 08:51:07 +0000 Message-ID: Date: Wed, 20 Mar 2024 09:51:06 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties To: FLAVIO SULIGOI , "lee@kernel.org" , "daniel.thompson@linaro.org" , "jingoohan1@gmail.com" , "deller@gmx.de" , "andy@kernel.org" , "geert@linux-m68k.org" , "dan.carpenter@linaro.org" , "sam@ravnborg.org" Cc: "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , "linux-staging@lists.linux.dev" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea References: <20240319093915.31778-1-tzimmermann@suse.de> <20240319093915.31778-7-tzimmermann@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.37 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spamd-Result: default: False [-3.37 / 50.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,gmx.de]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-1.87)[94.23%]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWELVE(0.00)[15]; DBL_BLOCKED_OPENRESOLVER(0.00)[linaro.org:email]; FREEMAIL_TO(0.00)[asem.it,kernel.org,linaro.org,gmail.com,gmx.de,linux-m68k.org,ravnborg.org]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1ydJY3KY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UWgIELCt X-Rspamd-Queue-Id: 108A834020 Hi Am 20.03.24 um 09:46 schrieb FLAVIO SULIGOI: > Hi Thomas, > > ... >> Remove the field fb_blank from struct backlight_properties and remove all >> code that still sets or reads it. Backlight blank status is now tracked exclusively >> in struct backlight_properties.state. >> >> The core backlight code keeps the fb_blank and state fields in sync, but doesn't >> do anything else with fb_blank. Several drivers initialize fb_blank to >> FB_BLANK_UNBLANK to enable the backlight. This is already the default for >> the state field. So we can delete the fb_blank code from core and drivers and >> rely on the state field. >> >> Signed-off-by: Thomas Zimmermann >> Cc: Flavio Suligoi >> Cc: Nicolas Ferre >> Cc: Alexandre Belloni >> Cc: Claudiu Beznea >> Tested-by: Flavio Suligoi >> Reviewed-by: Daniel Thompson >> Reviewed-by: Dan Carpenter > ... > > Can you explain what are the differences between the version 1 and version 2 of the patch? There are none. It's simply labeled v2 because it is part of the version 2 of this series. Best regards Thomas > Thanks, > Flavio -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)