From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: frequency: ad9834: clean up includes
Date: Fri, 17 Apr 2026 10:26:34 +0300 [thread overview]
Message-ID: <aeHgqpuSOxgqP6hK@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-yhUTYzHUkOqAQ+nunUrH=DqzCzMS=hW5ZxO5M46ETa8Q@mail.gmail.com>
On Fri, Apr 17, 2026 at 09:13:27AM +0200, Joshua Crofts wrote:
> On Fri, 17 Apr 2026 at 08:47, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > I'm wondering why in previous round the tool haven't noticed what I did...
>
> Yeah, the tool is pretty noisy unfortunately, even with tweaking it's
> not exactly 100%.
Yes, that's why one still needs to understand more about headers in the Linux
kernel to do such a "simple" change.
> > > +#include <linux/string.h>
> >
> > Hmm... What's used for here?
>
> sysfs_streq() is defined in linux/string.h.
Oh, surprise surprise :-), thanks for pointing this out!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-17 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 9:32 [PATCH v3] iio: frequency: ad9834: clean up includes Joshua Crofts
2026-04-17 6:47 ` Andy Shevchenko
2026-04-17 7:13 ` Joshua Crofts
2026-04-17 7:26 ` Andy Shevchenko [this message]
2026-04-17 7:34 ` Joshua Crofts
2026-04-19 16:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeHgqpuSOxgqP6hK@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox