Re: [PATCH] mips: cavium-octeon: remove cmd queue state and related typedefs

Maxwell Doose
2026-04-17T13:16:49Z

On Fri, Apr 17, 2026 at 12:25 AM Dan Carpenter <error27@gmail.com> wrote:
>
> This should be two different patches. Is there no way to move the
> variable declarations around first and then get rid of the typedef?
>
> regards,
> dan carpenter
>

When I was test-compiling the patch yesterday, sparse raised
a "should it be static?" error, and that was resolved by moving
the extern for the __cvmx_queue_state_ptr in the header to the
top of the file.

best regards,
maxwell doose