Re: [PATCH] mips: cavium-octeon: remove cmd queue state and related typedefs

Maxwell Doose
2026-04-17T14:46:09Z

On Fri, Apr 17, 2026 at 9:02 AM Dan Carpenter <error27@gmail.com> wrote:
>
> Generally, outside of staging, you just go along with whatever the
> original author wanted. They did the work after all, so they get to
> decide.

Sorry about that, still figuring out the workflow. I agree, the way they
did this is...interesting, to say the least, but if I try this again I'll drop
the extern move.

> This patch removes the declaration in __cvmx_cmd_queue_state_ptr() but
> leaves it in __cvmx_cmd_queue_get_state(). We definitely can't do that.
> And we can't mix this in with a remove typedefs patch.

Thanks for pointing that out, I must've missed it. If I try again I'll
fix it but given that this is mips and this stuff is usually for staging,
it's going to be unlikely unless a maintainer wants it.

thanks,
maxwell