Re: [PATCH] staging: atomisp: fix block comment style in atomisp_cmd.c

[Sakari Ailus <sakari.ailus@iki.fi>]

Hi Oskar,

On Sun, Mar 01, 2026 at 09:59:10PM +0100, Oskar Ray-Frayssinet wrote:
> Fix block comments to use the proper kernel coding style by adding
> * on subsequent lines and moving trailing */ to a separate line.
> 
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---
>  .../staging/media/atomisp/pci/atomisp_cmd.c   | 40 ++++++++++++-------
>  1 file changed, 25 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index fec369575d88..5bc1541b1e40 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1381,7 +1381,8 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
>  		return;
>  
>  	/* We must free all buffers because they no longer match
> -	   the grid size. */
> +	 * the grid size.
> +	 */

/*
 * Multi-line
 * comment.
 */

Same for the rest.

>  	atomisp_css_free_stat_buffers(asd);
>  
>  	err = atomisp_alloc_css_stat_bufs(asd, ATOMISP_INPUT_STREAM_GENERAL);
> @@ -1391,10 +1392,11 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
>  	}
>  
>  	if (atomisp_alloc_3a_output_buf(asd)) {
> -		/* Failure for 3A buffers does not influence DIS buffers */
> +		/* Failure for 3A buffers does not influence DIS buffers. */
>  		if (asd->params.s3a_output_bytes != 0) {
>  			/* For SOC sensor happens s3a_output_bytes == 0,
> -			 * using if condition to exclude false error log */
> +			 * using if condition to exclude false error log.
> +			 */
>  			dev_err(isp->dev, "Failed to allocate memory for 3A statistics\n");
>  		}
>  		goto err;
> @@ -1687,8 +1689,9 @@ int atomisp_3a_stat(struct atomisp_sub_device *asd, int flag,
>  
>  	if (atomisp_compare_grid(asd, &config->grid_info) != 0) {
>  		/* If the grid info in the argument differs from the current
> -		   grid info, we tell the caller to reset the grid size and
> -		   try again. */
> +		 * grid info, we tell the caller to reset the grid size and
> +		 * try again.
> +		 */
>  		return -EAGAIN;
>  	}
>  
> @@ -2463,8 +2466,9 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,
>  		    memcmp(&coefs->grid, cur, sizeof(coefs->grid))) {
>  			dev_err(asd->isp->dev, "dvs grid mismatch!\n");
>  			/* If the grid info in the argument differs from the current
> -			grid info, we tell the caller to reset the grid size and
> -			try again. */
> +			 * grid info, we tell the caller to reset the grid size and
> +			 * try again.
> +			 */
>  			return -EAGAIN;
>  		}
>  
> @@ -2519,8 +2523,9 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,
>  		    memcmp(&dvs2_coefs.grid, cur, sizeof(dvs2_coefs.grid))) {
>  			dev_err(asd->isp->dev, "dvs grid mismatch!\n");
>  			/* If the grid info in the argument differs from the current
> -			grid info, we tell the caller to reset the grid size and
> -			try again. */
> +			 * grid info, we tell the caller to reset the grid size and
> +			 * try again.
> +			 */
>  			return -EAGAIN;
>  		}
>  
> @@ -3027,7 +3032,8 @@ int atomisp_param(struct atomisp_sub_device *asd, int flag,
>  
>  		/* We always return the resolution and stride even if there is
>  		 * no valid metadata. This allows the caller to get the
> -		 * information needed to allocate user-space buffers. */
> +		 * information needed to allocate user-space buffers.
> +		 */
>  		config->metadata_config.metadata_height = asd->
>  			stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
>  			metadata_info.resolution.height;
> @@ -3278,7 +3284,8 @@ atomisp_bytesperline_to_padded_width(unsigned int bytesperline,
>  	case IA_CSS_FRAME_FORMAT_RGBA888:
>  		return bytesperline / 4;
>  	/* The following cases could be removed, but we leave them
> -	   in to document the formats that are included. */
> +	 * in to document the formats that are included.
> +	 */
>  	case IA_CSS_FRAME_FORMAT_NV11:
>  	case IA_CSS_FRAME_FORMAT_NV12:
>  	case IA_CSS_FRAME_FORMAT_NV16:
> @@ -3315,8 +3322,9 @@ atomisp_v4l2_framebuffer_to_css_frame(const struct v4l2_framebuffer *arg,
>  			   arg->fmt.bytesperline, sh_format);
>  
>  	/* Note: the padded width on an ia_css_frame is in elements, not in
> -	   bytes. The RAW frame we use here should always be a 16bit RAW
> -	   frame. This is why we bytesperline/2 is equal to the padded with */
> +	 * bytes. The RAW frame we use here should always be a 16bit RAW
> +	 * frame. This is why we bytesperline/2 is equal to the padded width.
> +	 */
>  	if (ia_css_frame_allocate(&res, arg->fmt.width, arg->fmt.height,
>  				       sh_format, padded_width, 0)) {
>  		ret = -ENOMEM;
> @@ -3926,7 +3934,8 @@ static inline int atomisp_set_sensor_mipi_to_isp(
>  	}
>  
>  	/* Compatibility for sensors which provide no media bus code
> -	 * in s_mbus_framefmt() nor support pad formats. */
> +	 * in s_mbus_framefmt() nor support pad formats.
> +	 */
>  	if (mipi_info && mipi_info->input_format != -1) {
>  		bayer_order = mipi_info->raw_bayer_order;
>  
> @@ -4385,7 +4394,8 @@ int atomisp_set_fmt(struct video_device *vdev, struct v4l2_format *f)
>  			V4L2_SEL_TGT_CROP);
>  
>  	/* Try to enable YUV downscaling if ISP input is 10 % (either
> -	 * width or height) bigger than the desired result. */
> +	 * width or height) bigger than the desired result.
> +	 */
>  	if (!IS_MOFD ||
>  	    isp_sink_crop.width * 9 / 10 < f->fmt.pix.width ||
>  	    isp_sink_crop.height * 9 / 10 < f->fmt.pix.height ||

-- 
Regards,

Sakari Ailus