From: Dan Carpenter <error27@gmail.com>
To: Yuma Ochi <ochiyuma.ochi@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] staging: rtl8723bs: Remove boolean comparisons
Date: Sat, 18 Apr 2026 17:55:11 +0300 [thread overview]
Message-ID: <aeObTxN4LGwjJRFx@stanley.mountain> (raw)
In-Reply-To: <20260418144916.361744-1-ochiyuma.ochi@gmail.com>
On Sat, Apr 18, 2026 at 10:49:16PM +0800, Yuma Ochi wrote:
> @@ -1950,8 +1950,8 @@ static int recv_indicatepkts_in_order(struct adapter *padapter, struct recv_reor
>
> /* indicate this recv_frame */
> if (!pattrib->amsdu) {
> - if ((padapter->bDriverStopped == false) &&
> - (padapter->bSurpriseRemoved == false))
> + if ((!padapter->bDriverStopped) &&
> + (!padapter->bSurpriseRemoved))
Originally the parentheses were not a problem, but now there are too many.
Same thing in other places as well.
> rtw_recv_indicatepkt(padapter, prframe);/* indicate this recv_frame */
>
> } else if (pattrib->amsdu == 1) {
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-18 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 14:49 [PATCH v1] staging: rtl8723bs: Remove boolean comparisons Yuma Ochi
2026-04-18 14:55 ` Dan Carpenter [this message]
2026-04-18 16:09 ` Yuma Ochi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeObTxN4LGwjJRFx@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ochiyuma.ochi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox