From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Abhai Kollara <abhai@protonmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep over msleep
Date: Sun, 19 Apr 2026 01:08:02 +0300 [thread overview]
Message-ID: <aeQAwiVqppOYy_5h@kekkonen.localdomain> (raw)
In-Reply-To: <20260418201755.2604188-1-abhai@protonmail.com>
Hi Abhai,
On Sat, Apr 18, 2026 at 08:18:01PM +0000, Abhai Kollara wrote:
> The gc2235 driver uses msleep(5) during power-up. msleep() is often
> imprecise for durations under 20ms. Replace it with fsleep()
> to provide better precision.
>
> Signed-off-by: Abhai Kollara <abhai@protonmail.com>
> ---
> v3:
> - Use fsleep() instead of usleep_range() per Sakari Ailus's feedback.
The commit 968d8904c2f86996b0615a08ee4048bccac56758 apparently already does
this in my atomisp branch.
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2026-04-18 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 21:27 [PATCH] staging: atomisp: gc2235: prefer usleep_range over msleep Abhai Kollara
2026-03-19 20:42 ` [PATCH v2] staging: media: " Abhai Kollara
2026-04-16 9:44 ` Sakari Ailus
2026-04-18 20:18 ` [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep " Abhai Kollara
2026-04-18 22:08 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeQAwiVqppOYy_5h@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=abhai@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox