From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Gabriel Sanches <gabriel@gsr.dev>
Cc: linux-staging@lists.linux.dev, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
sakari.ailus@linux.intel.com, mchehab@kernel.org,
hansg@kernel.org, andy@kernel.org, ~lkcamp/patches@lists.sr.ht,
koike@igalia.com
Subject: Re: [PATCH] media: atomisp: Use negation to check for NULL
Date: Fri, 24 Apr 2026 11:54:20 +0300 [thread overview]
Message-ID: <aesvvPPq35g2yHR0@ashevche-desk.local> (raw)
In-Reply-To: <20260423181443.46566-1-gabriel@gsr.dev>
On Thu, Apr 23, 2026 at 03:14:36PM -0300, Gabriel Sanches wrote:
...
> Hey, this is my first patch ever. I would appreciate any
> feedback. Thanks!
Please, start reviewing others' patches for the same driver and read other
reviews and learn from them first.
I'm not going to repeat what I said already several times on a patches like
this over the very same driver (atomisp).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-24 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 18:14 [PATCH] media: atomisp: Use negation to check for NULL Gabriel Sanches
2026-04-24 8:54 ` Andy Shevchenko [this message]
2026-04-28 1:58 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aesvvPPq35g2yHR0@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gabriel@gsr.dev \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=koike@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox