From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Everton Colombo <e.rcolombo2@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, andy@kernel.org, hansg@kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, ~lkcamp/patches@lists.sr.ht,
koike@igalia.com
Subject: Re: [PATCH] media: atomisp: Remove unnecessary function return
Date: Fri, 24 Apr 2026 11:55:53 +0300 [thread overview]
Message-ID: <aeswGWHvGTOxmu7a@ashevche-desk.local> (raw)
In-Reply-To: <20260423183814.84729-1-e.rcolombo2@gmail.com>
On Thu, Apr 23, 2026 at 03:38:14PM -0300, Everton Colombo wrote:
> ---
> Hey, this is my first patch! Any feedback would be appreciated!
Please, start reviewing others' patches for the same driver and read other
reviews and learn from them first.
I'm not going to repeat what I said already several times on a patches like
this over the very same driver (atomisp).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-24 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 18:38 [PATCH] media: atomisp: Remove unnecessary function return Everton Colombo
2026-04-24 8:55 ` Andy Shevchenko [this message]
2026-04-28 1:58 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeswGWHvGTOxmu7a@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=e.rcolombo2@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=koike@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox