From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: ia_css_isp_states: fix typo in ia_css_isp_states.c
Date: Wed, 29 Apr 2026 21:29:17 +0300 [thread overview]
Message-ID: <afJN_SzCzXTejFXR@ashevche-desk.local> (raw)
In-Reply-To: <20260429180148.6581-1-mahamaryamjavaid@gmail.com>
On Wed, Apr 29, 2026 at 02:01:48PM -0400, Maha Maryam Javaid wrote:
> Fix spelling mistake: commmit -> commit
NAK.
This has a few problems:
- wrong Subject
- not doing that across the whole driver
- repeating the work that has been already done and reviewed
- the previous work seems in a stale state, needs the review being addressed
(but I haven't checked that for sure)
Instead of doing this, start from reviewing others' patches and learn from
other reviews before doing your contributions.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-29 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 18:01 [PATCH] staging: media: ia_css_isp_states: fix typo in ia_css_isp_states.c Maha Maryam Javaid
2026-04-29 18:29 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afJN_SzCzXTejFXR@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mahamaryamjavaid@gmail.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox