From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jack Lee <skunkolee@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Josh Poimboeuf <jpoimboe@kernel.org>, Kees Cook <kees@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
"open list:STAGING - ATOMISP DRIVER"
<linux-media@vger.kernel.org>,
"open list:INTEL MID (Mobile Internet Device) PLATFORM"
<linux-kernel@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>
Subject: Re: [PATCH] staging: media: atomisp: ov2722: clean up ov2722_startup()
Date: Thu, 30 Apr 2026 09:05:44 +0300 [thread overview]
Message-ID: <afLxOIy_RwjzltcG@ashevche-desk.local> (raw)
In-Reply-To: <20260429234110.7879-1-skunkolee@gmail.com>
On Wed, Apr 29, 2026 at 05:41:06PM -0600, Jack Lee wrote:
> Remove stale TODO comment that has been present since the file
> was first added to staging in 2017 and was never really acted on.
> Also replace return ret with return 0 since ret is guaranteed
> to be zero at that point, both write calls return early on
> failure.
NAK. This is not a real change. It has no value on itself.
Moreover, it removes a comment without actually addressing it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-30 6:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 23:41 [PATCH] staging: media: atomisp: ov2722: clean up ov2722_startup() Jack Lee
2026-04-30 6:05 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-29 2:03 auth
2026-04-29 5:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afLxOIy_RwjzltcG@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mingo@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=skunkolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox