From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53FF72 for ; Fri, 12 Nov 2021 16:31:07 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id d11so19600341ljg.8 for ; Fri, 12 Nov 2021 08:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=10KMDDU+DaSIDbG4KLnwkKUabZtwZOoBI/YHPLaepm8=; b=lYNoIGAzCqLDgiOPcZXWaYhuk/NMieSo8L8NBUujzpvCzpizz14ynUgsIxWJcABFNm Cq0aN7F7xjXniy9tNJkGxfAqeNdm0h95Gcs227oq6Voho3VXszHNiDQQnMxEFIymhbs9 zAChlzCteZjM3TczYklsTCBRn+3oS0q+HCHSpN5DttFGk88SLrxEmH9ZGmOYEQ5QzBs0 r6SWULmqSbHlM02KHy2gVbLsVL7Bzegy9tkGPnX0RTjbPNelawMPoNOygkXtfEK1qWAa gRMSx7cZe70hHKC1TLbq7ivHgpWakRWBp/AdYGxFhptGD17yl+gMNQOgbA5Y8pZegw8Z Jt9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=10KMDDU+DaSIDbG4KLnwkKUabZtwZOoBI/YHPLaepm8=; b=XSpBNT1F6bYkrkHlovcLw+8FmQiUBJUmBoFNxCxJ1K9ROG6DLuKmDeZY+91QyWGyku Jz4ycT1vzVJdEpKgyWmtEEx8mCFKA6VRJQ0Nic0fdoCKdSZnIFsckn4XZ/VCDBTCOyTV SPfqMTsz5yNYs03JCJoDyvgnoWlMcPStR51T2AIMe2GX+s/rl4yiAIzrwkUGUK4y1ILW Zf1gfn/A3frlsTsnf77IqUTEibBAJI6UKGvG5Nau1K0GfhfkgI7lol0Gto4DGiu1x+Aj mlqI0yilgZMpB/kuDjr58V2KoHjnNp9wgMPAOb1E1O5+hNDDCF/QAgGkcQ8QkUIIdtK+ ST/w== X-Gm-Message-State: AOAM533AHiL4obbmpqj22Ah5jNduGucI+Naje5jcjv+LVNn2GZbWCWB3 kc4sWw5mcbQfrYx44AcvCGU= X-Google-Smtp-Source: ABdhPJwvss7U2lYl+ogC+1ZI1w3j7qlIWufbl8KUwKR9aUXGd9w3OK2jiJR1ZGGt8o4ZhFSXp2nmAQ== X-Received: by 2002:a05:651c:891:: with SMTP id d17mr16605087ljq.199.1636734665752; Fri, 12 Nov 2021 08:31:05 -0800 (PST) Received: from [192.168.1.11] ([94.103.224.112]) by smtp.gmail.com with ESMTPSA id n3sm600479ljc.92.2021.11.12.08.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Nov 2021 08:31:05 -0800 (PST) Message-ID: Date: Fri, 12 Nov 2021 19:31:04 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] staging: r8188eu: remove unneeded variable Content-Language: en-US To: cgel.zte@gmail.com, phil@philpotter.co.uk Cc: Larry.Finger@lwfinger.net, straube.linux@gmail.com, linux@roeck-us.net, martin@kaiser.cx, dan.carpenter@oracle.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Changcheng Deng , Zeal Robot References: <20211112131830.11418-1-deng.changcheng@zte.com.cn> From: Pavel Skripkin In-Reply-To: <20211112131830.11418-1-deng.changcheng@zte.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/12/21 16:18, cgel.zte@gmail.com wrote: > From: Changcheng Deng > > Fix the following coccicheck review: > ./drivers/staging/r8188eu/core/rtw_ap.c: 1094: 5-8: Unneeded variable > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > drivers/staging/r8188eu/core/rtw_ap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c > index c78feeb9c862..d103a92ee2f1 100644 > --- a/drivers/staging/r8188eu/core/rtw_ap.c > +++ b/drivers/staging/r8188eu/core/rtw_ap.c > @@ -1091,7 +1091,6 @@ u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta, > int rtw_sta_flush(struct adapter *padapter) > { > struct list_head *phead, *plist; > - int ret = 0; None of the existing callers check the return value of this function. Make it void, please. With regards, Pavel Skripkin