From: ascordeiro <alinesantanacordeiro@gmail.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
Julia Lawall <julia.lawall@inria.fr>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case
Date: Fri, 09 Apr 2021 15:26:08 -0300 [thread overview]
Message-ID: <aff7af9caab6fab8ec2c7ee0980669323b449aa9.camel@gmail.com> (raw)
In-Reply-To: <532a72f6fcb6f51451e12444413c0ad4441a679d.camel@collabora.com>
Em sex, 2021-04-09 às 14:42 -0300, Ezequiel Garcia escreveu:
> On Fri, 2021-04-09 at 19:25 +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 9 Apr 2021, ascordeiro wrote:
> >
> > > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu:
> > > > Hi Aline,
> > >
> > > Hi Ezequiel,
> > > >
> > > > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro
> > > > wrote:
> > > > > Rewrite macros resembling functions #define
> > > > > HANTRO_PP_REG_WRITE
> > > > > and #define HANTRO_PP_RED_WRITE_S in lower case, according
> > > > > with
> > > > > code style.
> >
> > Maybe you can see if these macros can be converted to static inline
> > functions. Macros don't provide any type checking.
> >
>
> I'd like to leave these as they are for now, tbh ^_^
>
> A more massive refactoring is needed in this driver,
> but it needs proper testing and it's a more complex plan.
Okay, thank you for your attention :)
Aline
>
> Thanks!
> Ezequiel
>
prev parent reply other threads:[~2021-04-09 18:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 13:54 [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case Aline Santana Cordeiro
2021-04-09 16:44 ` Ezequiel Garcia
2021-04-09 17:00 ` ascordeiro
2021-04-09 17:15 ` Ezequiel Garcia
2021-04-09 17:36 ` ascordeiro
2021-04-09 17:25 ` Julia Lawall
2021-04-09 17:39 ` ascordeiro
2021-04-09 17:42 ` Ezequiel Garcia
2021-04-09 18:26 ` ascordeiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aff7af9caab6fab8ec2c7ee0980669323b449aa9.camel@gmail.com \
--to=alinesantanacordeiro@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox