Re: [PATCH 5/5] staging: rtl8723bs: propagate errno through hal xmit path

[Dan Carpenter <error27@gmail.com>]

On Thu, May 14, 2026 at 06:03:23AM +0000, Hungyu Lin wrote:
> Propagate errno values from rtl8723bs_hal_xmitframe_enqueue()
> through rtw_hal_xmitframe_enqueue() by returning the error code
> directly.
> 
> Also update rtw_hal_xmit() to explicitly map the boolean return
> value of rtl8723bs_hal_xmit() to _SUCCESS/_FAIL, clarifying
> the return semantics at the HAL boundary.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>

I was onboard with this patchset up to this point.  The "Also update"
part legit confused me when I was reading the patch.  I don't see how
that's related.

The second thing which confused me was that I was expecting the patch
to update the callers of rtw_hal_xmitframe_enqueue().  It turns out
that none of the caller check for errors.  This can be fine in
networking, in an xmit error case we pretend that we succeeded and
that the network ate our packets.  Very normal.  However, when I'm
reading the patch I want a comment to say, "None of the callers of
rtw_hal_xmitframe_enqueue() check for errors so they don't need to
be updated and this has no effect on runtime."

regards,
dan carpenter