From: Dan Carpenter <error27@gmail.com>
To: Moksh Panicker <mokshpanicker.7@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org
Subject: Re: [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c
Date: Sat, 16 May 2026 13:17:15 +0300 [thread overview]
Message-ID: <aghEK3CCbfhYQ-T8@stanley.mountain> (raw)
In-Reply-To: <20260516095103.12727-2-mokshpanicker.7@gmail.com>
On Sat, May 16, 2026 at 09:51:02AM +0000, Moksh Panicker wrote:
> Add missing braces to the else clause to satisfy the coding style
> requirement that both arms of an if/else statement use braces.
>
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 987d05816c5c..2be74f2d4ac8 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -73,7 +73,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
> break;
> }
> return rtw_read8(Adapter, EFUSE_CTRL);
> - } else
> + } else {
> return 0xFF;
>
> } /* rtw_efuse_read_1_byte */
Always compile test your code. Also why did you send this patch
twice?
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-16 10:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 9:51 [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
2026-05-16 9:51 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
2026-05-16 10:17 ` Dan Carpenter [this message]
2026-05-16 11:39 ` Moksh Panicker
2026-05-16 9:51 ` [PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature Moksh Panicker
2026-05-16 10:27 ` [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 1:33 Moksh Panicker
2026-05-15 1:33 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aghEK3CCbfhYQ-T8@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=mokshpanicker.7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox