From: Dan Carpenter <error27@gmail.com>
To: lixinyu <xinyuili@126.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: rtl8723bs: add missing spaces around operators in rtl8723b_hal_init.c
Date: Tue, 19 May 2026 17:06:00 +0300 [thread overview]
Message-ID: <agxuSN4ZIVKzF9zI@stanley.mountain> (raw)
In-Reply-To: <20260519094633.869233-3-xinyuili@126.com>
On Tue, May 19, 2026 at 05:46:33PM +0800, lixinyu wrote:
> Add missing spaces around binary operators (|, &, +, >>) to comply
> with kernel coding style. This includes spacing fixes for register
> offset patterns, bitwise operations on function arguments, array
> index arithmetic, and bit shift operations.
>
> Assisted-by: Claude:claude-4-opus
> ---
Wait a day between resends.
Read the email I sent earlier again. Use checkpatch etc.
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-19 14:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 9:01 [PATCH] staging: rtl8723bs: fix coding style issues in rtl8723b_hal_init.c lixinyu
2026-05-19 9:34 ` Dan Carpenter
2026-05-19 9:46 ` Greg Kroah-Hartman
2026-05-19 9:46 ` [PATCH v2 0/2] " lixinyu
2026-05-19 9:46 ` [PATCH v2 1/2] staging: rtl8723bs: replace C++ style comments with kernel style lixinyu
2026-05-19 9:46 ` [PATCH v2 2/2] staging: rtl8723bs: add missing spaces around operators in rtl8723b_hal_init.c lixinyu
2026-05-19 14:06 ` Dan Carpenter [this message]
2026-05-19 9:57 ` [PATCH v3 0/2] staging: rtl8723bs: fix coding style issues " lixinyu
2026-05-19 9:57 ` [PATCH v3 1/2] staging: rtl8723bs: replace C++ style comments with kernel style lixinyu
2026-05-19 9:57 ` [PATCH v3 2/2] staging: rtl8723bs: add missing spaces around operators in rtl8723b_hal_init.c lixinyu
2026-05-19 9:59 ` [PATCH v4 0/2] staging: rtl8723bs: fix coding style issues " lixinyu
2026-05-19 9:59 ` [PATCH v4 1/2] staging: rtl8723bs: replace C++ style comments with kernel style lixinyu
2026-05-19 10:09 ` Greg Kroah-Hartman
2026-05-19 9:59 ` [PATCH v4 2/2] staging: rtl8723bs: add missing spaces around operators in rtl8723b_hal_init.c lixinyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agxuSN4ZIVKzF9zI@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=xinyuili@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox