From: Dan Carpenter <error27@gmail.com>
To: Colton Spurgin <colton@coltonspurgin.tech>
Cc: gregkh@linuxfoundation.org, vaibhav.sr@gmail.com,
mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager_module: add newlines to sysfs_emit calls
Date: Mon, 1 Jun 2026 14:12:17 +0300 [thread overview]
Message-ID: <ah1pEXtwjVpdHXs7@stanley.mountain> (raw)
In-Reply-To: <20260531005007.98382-1-colton@coltonspurgin.tech>
On Sat, May 30, 2026 at 07:50:07PM -0500, Colton Spurgin wrote:
> sysfs_emit() format strings should include a terminating newline.
> Add missing '\n' after 6 formatted strings in show functions.
>
> Signed-off-by: Colton Spurgin <colton@coltonspurgin.tech>
This checkpatch warning only applies to new code. For existing code
you risk breaking userspace.
regards,
dan carpenter
prev parent reply other threads:[~2026-06-01 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 0:50 [PATCH] staging: greybus: audio_manager_module: add newlines to sysfs_emit calls Colton Spurgin
2026-06-01 11:12 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah1pEXtwjVpdHXs7@stanley.mountain \
--to=error27@gmail.com \
--cc=colton@coltonspurgin.tech \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox