From: Dan Carpenter <error27@gmail.com>
To: Manuel Ebner <manuelebner@mailbox.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Omer El Idrissi <omer.e.idrissi@gmail.com>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] staging: cleanup of sdio_intf.c
Date: Fri, 22 May 2026 16:02:22 +0300 [thread overview]
Message-ID: <ahBT3r8ob5Zbq_Fc@stanley.mountain> (raw)
In-Reply-To: <20260522114317.189368-4-manuelebner@mailbox.org>
On Fri, May 22, 2026 at 01:43:20PM +0200, Manuel Ebner wrote:
> did i overdo the split up?
>
The split is fine. The subsystem prefix needs to be improved. The
capitalization and puncuation in the commit message could be improved
as well.
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-22 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 11:43 [PATCH v2 0/3] staging: cleanup of sdio_intf.c Manuel Ebner
2026-05-22 11:55 ` [PATCH v2 1/3] staging: sdio_intf.c: refactor function Manuel Ebner
2026-05-22 11:57 ` [PATCH v2 2/3] staging: cleanup whitespace of sdio_intf.c Manuel Ebner
2026-05-23 4:17 ` Greg KH
2026-05-22 11:58 ` [PATCH v2 3/3] staging: cleanup braces " Manuel Ebner
2026-05-22 13:02 ` Dan Carpenter [this message]
2026-05-22 15:33 ` [PATCH v2 0/3] staging: cleanup " Manuel Ebner
2026-05-22 16:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahBT3r8ob5Zbq_Fc@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manuelebner@mailbox.org \
--cc=omer.e.idrissi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox