From: Dan Carpenter <error27@gmail.com>
To: Igor Putko <igorpetindev@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces and fix indentation in HalPhyRf.c
Date: Mon, 25 May 2026 09:48:51 +0300 [thread overview]
Message-ID: <ahPw0yB7Ax3lfhKu@stanley.mountain> (raw)
In-Reply-To: <20260524175247.5229-1-igorpetindev@gmail.com>
On Sun, May 24, 2026 at 08:52:47PM +0300, Igor Putko wrote:
> Fixed braces around single statement blocks and corrected indentation
> to follow the Linux kernel coding style.
You're going to need to split this into multiple patches.
> @@ -230,14 +229,11 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter)
> /* else if (pDM_Odm->RFCalibrateInfo.CCK_index < 0) */
> /* pDM_Odm->RFCalibrateInfo.CCK_index = 0; */
> } else {
> - for (p = RF_PATH_A; p < c.RfPathCount; p++)
> - pDM_Odm->RFCalibrateInfo.PowerIndexOffset[p] = 0;
> + for (p = RF_PATH_A; p < c.RfPathCount; p++)
> + pDM_Odm->RFCalibrateInfo.PowerIndexOffset[p] = 0;
> }
>
> /* Print Swing base & current */
> - for (p = RF_PATH_A; p < c.RfPathCount; p++) {
> - }
> -
The comment makes no sense now.
> if (
> (pDM_Odm->RFCalibrateInfo.PowerIndexOffset[RF_PATH_A] != 0 ||
> pDM_Odm->RFCalibrateInfo.PowerIndexOffset[RF_PATH_B] != 0) &&
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-25 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 17:52 [PATCH] staging: rtl8723bs: remove unnecessary braces and fix indentation in HalPhyRf.c Igor Putko
2026-05-25 6:48 ` Dan Carpenter [this message]
2026-05-25 12:10 ` [PATCH 1/3] staging: rtl8723bs: remove empty loop and stale comment " Igor Putko
2026-05-25 12:10 ` [PATCH 2/3] staging: rtl8723bs: fix coding style for PowerIndexOffset initialization Igor Putko
2026-05-25 12:10 ` [PATCH 3/3] staging: rtl8723bs: fix coding style for TxPwrTrackSetPwr calls Igor Putko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahPw0yB7Ax3lfhKu@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=igorpetindev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox