From: Dan Carpenter <error27@gmail.com>
To: Jad Keskes <inasj268@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] staging: iio: impedance-analyzer: fix CamelCase in ad5933
Date: Wed, 3 Jun 2026 09:33:42 +0300 [thread overview]
Message-ID: <ah_Kxh6A9YaArwrU@stanley.mountain> (raw)
In-Reply-To: <20260602201428.213890-1-inasj268@gmail.com>
On Tue, Jun 02, 2026 at 09:14:28PM +0100, Jad Keskes wrote:
> checkpatch flagged mixed-case suffixes in #define names: _mVpp and _Hz.
> Rename to _MV_PP and _HZ to follow kernel UPPER_SNAKE_CASE convention.
>
These are scientific things. milli vs Mega etc. The capitalization
makes it a million times different from each other. We have to be
correct instead of following checkpatch.
regards,
dan carpenter
prev parent reply other threads:[~2026-06-03 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 20:14 [PATCH] staging: iio: impedance-analyzer: fix CamelCase in ad5933 Jad Keskes
2026-06-03 6:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah_Kxh6A9YaArwrU@stanley.mountain \
--to=error27@gmail.com \
--cc=inasj268@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox