From: Dan Carpenter <error27@gmail.com>
To: Dorian Catric <dorian.catric@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
marvin24@gmx.de
Subject: Re: [PATCH] staging: nvec: fix coding style issues in nvec.c
Date: Wed, 3 Jun 2026 09:35:11 +0300 [thread overview]
Message-ID: <ah_LHzrIKqajkYqj@stanley.mountain> (raw)
In-Reply-To: <20260602205252.3336-1-dorian.catric@gmail.com>
On Tue, Jun 02, 2026 at 10:52:52PM +0200, Dorian Catric wrote:
> Fix three coding style issues detected by checkpatch.pl:
>
> - Fix typo in URL: 'lauchpad.net' -> 'launchpad.net' in the copyright
> header (nvec.h already has the correct spelling)
> - Remove extra space in 'enum nvec_msg_category {' declaration
> - Convert EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL() for nvec_write_async()
> and nvec_write_sync() to match the other exported symbols in this driver
Probably needs all be separate patches. The EXPORT_SYMBOL() to
EXPORT_SYMBOL_GPL() conversion is controversial and not a checkpatch
issue.
regards,
dan carpenter
prev parent reply other threads:[~2026-06-03 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 20:52 [PATCH] staging: nvec: fix coding style issues in nvec.c Dorian Catric
2026-06-03 6:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah_LHzrIKqajkYqj@stanley.mountain \
--to=error27@gmail.com \
--cc=dorian.catric@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox