From: Dan Carpenter <error27@gmail.com>
To: Lucas Faria Mendes <lucas.fariamo08@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix CamelCase macros by converting to uppercase with underscores
Date: Thu, 28 May 2026 10:24:24 +0300 [thread overview]
Message-ID: <ahftqCfnQceIw2_H@stanley.mountain> (raw)
In-Reply-To: <20260527191203.494292-1-lucas.fariamo08@gmail.com>
On Wed, May 27, 2026 at 04:12:03PM -0300, Lucas Faria Mendes wrote:
> Fix the following CHECK style issues reported by checkpatch.pl:
> Avoid CamelCase: <VME_2eVME>
> Avoid CamelCase: <VME_2eSST>
> Avoid CamelCase: <VME_2eSSTB>
> Avoid CamelCase: <VME_2eSST160>
> Avoid CamelCase: <VME_2eSST267>
> Avoid CamelCase: <VME_2eSST320>
>
> Convert the lowercase 'e' to uppercase 'E' and separate the protocol
> naming elements using underscores (e.g., VME_2E_VME). Update all macro
> definitions in vme.h and their respective usages across the driver
> files to comply with the Linux kernel coding style.
>
No. The original is the correct way. Here correctness is more
important than the CamelCase rule.
regards,
dan carpenter
prev parent reply other threads:[~2026-05-28 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 19:12 [PATCH] staging: vme_user: fix CamelCase macros by converting to uppercase with underscores Lucas Faria Mendes
2026-05-28 7:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahftqCfnQceIw2_H@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.fariamo08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox