From: Dan Carpenter <error27@gmail.com>
To: Dawei Feng <dawei.feng@seu.edu.cn>
Cc: gregkh@linuxfoundation.org, omer.e.idrissi@gmail.com,
hansg@kernel.org, hi@josie.lol, straube.linux@gmail.com,
xela@viard.dev, ethantidmore06@gmail.com, liangjie@lixiang.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
jianhao.xu@seu.edu.cn, Zilin Guan <zilin@seu.edu.cn>
Subject: Re: [PATCH] staging: rtl8723bs: fix mismatched free of HalData in rtw_sdio_if1_init()
Date: Thu, 28 May 2026 10:30:18 +0300 [thread overview]
Message-ID: <ahfvCpI6YOA9Gpyh@stanley.mountain> (raw)
In-Reply-To: <20260525091836.812565-1-dawei.feng@seu.edu.cn>
On Mon, May 25, 2026 at 05:18:36PM +0800, Dawei Feng wrote:
> padapter->HalData is allocated via vzalloc(), but incorrectly freed
> using kfree() in the rtw_sdio_if1_init() error path. Using kfree() to
> release this vmalloc-backed buffer can lead to memory corruption.
>
> Use rtw_hal_data_deinit() to pair the free correctly and free
> HalData with vfree().
>
> The bug was first flagged by an experimental static analysis tool we
> are developing for kernel memory-management bugs.
The rest of the commit message from HERE
> Manual inspection
> confirms that the issue is still present in current mainline.
>
> An x86_64 allyesconfig build showed no new warnings. As we do not have
> suitable RTL8723BS SDIO hardware to test with, no runtime testing was
> able to be performed.
to HERE should be put
>
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
> Signed-off-by: Dawei Feng <dawei.feng@seu.edu.cn>
> ---
^^^
Here under the --- cut off line. We don't need this kind of meta
commentary about testing in the permanent git log. Otherwise
the patch is correct.
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-28 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 9:18 [PATCH] staging: rtl8723bs: fix mismatched free of HalData in rtw_sdio_if1_init() Dawei Feng
2026-05-28 7:30 ` Dan Carpenter [this message]
2026-05-28 10:15 ` Dawei Feng
2026-05-28 10:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahfvCpI6YOA9Gpyh@stanley.mountain \
--to=error27@gmail.com \
--cc=dawei.feng@seu.edu.cn \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=hi@josie.lol \
--cc=jianhao.xu@seu.edu.cn \
--cc=liangjie@lixiang.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=omer.e.idrissi@gmail.com \
--cc=straube.linux@gmail.com \
--cc=xela@viard.dev \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox