From: Dan Carpenter <error27@gmail.com>
To: Moksh Panicker <mokshpanicker.7@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH v1 0/4] staging: rtl8723bs: Fix missing spaces around operators
Date: Mon, 15 Jun 2026 10:28:13 +0300 [thread overview]
Message-ID: <ai-pjZQbgUiqMAgt@stanley.mountain> (raw)
In-Reply-To: <20260614122155.20034-1-mokshpanicker.7@gmail.com>
On Sun, Jun 14, 2026 at 12:21:51PM +0000, Moksh Panicker wrote:
> This patch series fixes missing spaces around arithmetic and bitwise
> operators ('+',' -', '&') in the rtl8723bs staging driver. These were
> flagged by checkpatch.pl with:
>
> CHECK: spaces preferred around that 'X' (ctx:VxV)
>
> Each patch addresses one file independently.
>
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
>
> Moksh Panicker (4):
> staging: rtl8723bs: Fix missing space around '+' operator in
> hal_sdio.c
> staging: rtl8723bs: Fix missing space around '-' operator in
> hal_com_phycfg.c
> staging: rtl8723bs: Fix missing spaces around operators in
> HalPwrSeqCmd.c
> staging: rtl8723bs: Fix missing spaces around '-' operator in
> HalPhyRf.c
>
> drivers/staging/rtl8723bs/hal/HalPhyRf.c | 8 ++++----
> drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 6 +++---
> drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +-
> drivers/staging/rtl8723bs/hal/hal_sdio.c | 2 +-
> 4 files changed, 9 insertions(+), 9 deletions(-)
Just combine all 4 patches into one patch.
regards,
dan carpenter
prev parent reply other threads:[~2026-06-15 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 12:21 [PATCH v1 0/4] staging: rtl8723bs: Fix missing spaces around operators Moksh Panicker
2026-06-14 12:21 ` [PATCH v1 1/4] staging: rtl8723bs: Fix missing space around '+' operator in hal_sdio.c Moksh Panicker
2026-06-15 7:26 ` Dan Carpenter
2026-06-14 12:21 ` [PATCH v1 2/4] staging: rtl8723bs: Fix missing space around '-' operator in hal_com_phycfg.c Moksh Panicker
2026-06-14 12:21 ` [PATCH v1 3/4] staging: rtl8723bs: Fix missing spaces around operators in HalPwrSeqCmd.c Moksh Panicker
2026-06-14 12:21 ` [PATCH v1 4/4] staging: rtl8723bs: Fix missing spaces around '-' operator in HalPhyRf.c Moksh Panicker
2026-06-15 7:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai-pjZQbgUiqMAgt@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mokshpanicker.7@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox