From: Dan Carpenter <error27@gmail.com>
To: William Elder <williamxelder@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: remove comparisons to boolean literals
Date: Thu, 4 Jun 2026 10:59:55 +0300 [thread overview]
Message-ID: <aiEwe3Ijva7hl1pH@stanley.mountain> (raw)
In-Reply-To: <20260603195239.200775-1-williamxelder@gmail.com>
On Wed, Jun 03, 2026 at 01:52:39PM -0600, William Elder wrote:
> Remove comparisons to true and false as they are error prone.
> Use the idiomatic C forms instead
> v2: Fix inverted logic for ht_option checks
Nope. Still buggy.
Please wait a day between resends.
There are other issues with this patch. It needs to be split up.
v2 rules etc.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
prev parent reply other threads:[~2026-06-04 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 19:52 [PATCH v2] staging: rtl8723bs: remove comparisons to boolean literals William Elder
2026-06-03 20:07 ` Ahmet Sezgin Duran
2026-06-03 20:32 ` William Elder
2026-06-04 7:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiEwe3Ijva7hl1pH@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=williamxelder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox