From: Dan Carpenter <error27@gmail.com>
To: Quentin Strydom <qstrydom0@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] staging: rtl8723bs: hal: fix whitespace in sdio_halinit.c
Date: Thu, 11 Jun 2026 19:53:06 +0300 [thread overview]
Message-ID: <airn8qdTbAYFWLuz@stanley.mountain> (raw)
In-Reply-To: <20260611162128.57870-1-qstrydom0@gmail.com>
On Thu, Jun 11, 2026 at 05:21:20PM +0100, Quentin Strydom wrote:
> Remove spaces before tabs in comments to match kernel coding style.
>
> Signed-off-by: Quentin Strydom <qstrydom0@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 54 ++++++++++----------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index f2f73c65a636..694cd4eca970 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -46,7 +46,7 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
> u16 value16;
> u32 value32;
> u8 ret;
> -/* u8 bMacPwrCtrlOn; */
> +/* u8 bMacPwrCtrlOn; */
You're not working against current code. Use linux-next or staging-next.
We don't reformat commented out code, we just delete it.
regards,
dan carpenter
prev parent reply other threads:[~2026-06-11 16:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 16:21 [PATCH 1/9] staging: rtl8723bs: hal: fix whitespace in sdio_halinit.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 2/9] staging: rtl8723bs: hal: fix whitespace in HalBtc8723b2Ant.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 3/9] staging: rtl8723bs: hal: fix whitespace in hal_btcoex.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 4/9] staging: rtl8723bs: hal: fix whitespace in hal_com.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 5/9] staging: rtl8723bs: hal: fix whitespace in HalPhyRf_8723B.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 6/9] staging: rtl8723bs: hal: fix whitespace in rtl8723b_cmd.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 7/9] staging: rtl8723bs: hal: fix whitespace in rtl8723b_dm.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 8/9] staging: rtl8723bs: hal: fix whitespace in rtl8723b_hal_init.c Quentin Strydom
2026-06-11 16:21 ` [PATCH 9/9] staging: rtl8723bs: hal: fix whitespace in rtl8723bs_recv.c Quentin Strydom
2026-06-11 16:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=airn8qdTbAYFWLuz@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=qstrydom0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox