From: Dan Carpenter <error27@gmail.com>
To: Brock Haftner <brockhaftner@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy@lists.linux.dev, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio: add missing newline to sysfs_emit formats
Date: Sat, 13 Jun 2026 09:17:04 +0300 [thread overview]
Message-ID: <aiz14CLCduz7996E@stanley.mountain> (raw)
In-Reply-To: <aiz1bMmAN-gQnm9x@stanley.mountain>
On Sat, Jun 13, 2026 at 09:15:08AM +0300, Dan Carpenter wrote:
> On Fri, Jun 12, 2026 at 06:49:05PM -0700, Brock Haftner wrote:
> > The sysfs_emit() function is used to format strings that are returned
> > to userspace. According to the sysfs documentation, these outputs
> > should include a newline character for visual clarity.
> >
> > Fix the checkpatch.pl warnings by adding the missing '\n' to the
> > sysfs_emit() format strings inside several functions.
> >
> > Signed-off-by: Brock Haftner <brockhaftner@gmail.com>
>
> Please don't do this for existing code, only for new code. There
> is a risck that user space relies on the old behavior.
We should delete this checkpatch warning really. It could be a
sashiko rule which only applies for patches which introduce new
functions or something.
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-13 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 1:49 [PATCH] staging: greybus: audio: add missing newline to sysfs_emit formats Brock Haftner
2026-06-13 6:15 ` Dan Carpenter
2026-06-13 6:17 ` Dan Carpenter [this message]
2026-06-13 15:38 ` Brock Haftner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiz14CLCduz7996E@stanley.mountain \
--to=error27@gmail.com \
--cc=brockhaftner@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=outreachy@lists.linux.dev \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox