From: Dan Carpenter <error27@gmail.com>
To: suryasaimadhu <suryasaimadhu369@gmail.com>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add comments to mutex declarations
Date: Thu, 25 Jun 2026 13:26:44 +0300 [thread overview]
Message-ID: <aj0CZOUlYlJydfPd@stanley.mountain> (raw)
In-Reply-To: <20260625085740.222486-1-suryasaimadhu369@gmail.com>
On Thu, Jun 25, 2026 at 04:57:40PM +0800, suryasaimadhu wrote:
> Add comments to mutex members in gbaudio_codec_info struct
> to describe what each mutex protects, as recommended by checkpatch.
>
> Signed-off-by: suryasaimadhu <suryasaimadhu369@gmail.com>
Capital letters? Is this how you would write your name on a legal
document?
I kind of hate this checkpatch warning. What I want is a document,
not part of sentence... The document could go in the commit message
if you want, but I really want some thought to go into it, otherwise
it's sort of useless.
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-25 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 8:57 [PATCH] staging: greybus: add comments to mutex declarations suryasaimadhu
2026-06-25 10:26 ` Dan Carpenter [this message]
2026-06-25 10:45 ` [PATCH v2] " suryasaimadhu
2026-06-25 10:48 ` Sai Madhu
2026-06-25 11:16 ` [PATCH] staging: greybus: add meaningful " suryasaimadhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aj0CZOUlYlJydfPd@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=suryasaimadhu369@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox