From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 460F83624B3 for ; Tue, 16 Jun 2026 11:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781607717; cv=none; b=ce5PbLeNDVnYLGulNfzOs6Vf4m9bC8hL1yqYlS2MBRuYQbRoMO5z6kiZBGHamRlFCURx+t4kpM+50B24HRVaiTVO0qWSKOsK50/xeD2lAhZM9kRKXH7gP8580KJQi9F2LfUyxF/VE7OW9jnZVm3jimnTTKXQWfe9NGrsaP8UhDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781607717; c=relaxed/simple; bh=p4d1amCcedwI1v3xqzug5CnPQ8gUoAn3v47/+9BBe5w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lFYucYOVq4m4So0W52do13cNUnkA5voWzuLZAWB2UEDa6Nb+yiDe+BXA0TrPGUHtPDr1ChJ5Ntjxs7tVcs9Ra+mM5U5YJGLz7MaURNV6QjJNBe7EmlB8d7Qctl+cbd7ov7cjmIm0K/NL5o9UhQn8U4aToaXDQioNwGt9dmaH6aY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BDwd3upS; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BDwd3upS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781607715; x=1813143715; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=p4d1amCcedwI1v3xqzug5CnPQ8gUoAn3v47/+9BBe5w=; b=BDwd3upSm0k1FiRHYsTZh67VnlIfd7wGIom2VYMmyfQukikZ8OiObNdy bx0fvCNwaqBodf9BG2hh09s9gQ4BtdM1nzqSTraGpHgRd1JGZH9tBDcX2 dryDWLQUa77nJbOo4R5lOFKhgX3vksAEH+3mcvTKxnb8dc6BfvY4985Jr P8kUPufT0KeNYxJ5qH11PWTN5/eN7BP188lvKXtZas1oFqw5uV4tOqIra gXUn9jb3RRFWI+9inbXx2HTarNixBu7iqpdkLc52Y5Q8aFfKSHrDUUt8i 14r1O94mDW4CSQRmLpQJdGdE2X0qK7ZwvDTC4tDOtT78gWMFCX3P21bbL A==; X-CSE-ConnectionGUID: kO85Vp/URUafDlklmfJZJQ== X-CSE-MsgGUID: Sw1C7Pd/SfK3EXTd6gq2JQ== X-IronPort-AV: E=McAfee;i="6800,10657,11818"; a="81377612" X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="81377612" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2026 04:01:54 -0700 X-CSE-ConnectionGUID: SnTGqHIjQVC2mTdyxS1hAQ== X-CSE-MsgGUID: 9i6vCf4+SSq80ut0e54RHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,208,1774335600"; d="scan'208";a="285852468" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.153]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2026 04:01:53 -0700 Date: Tue, 16 Jun 2026 14:01:49 +0300 From: Andy Shevchenko To: Andrei Khomenkov Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-media@vger.kernel.org Subject: Re: [PATCH v3] media: atomisp: replace kmalloc() with kmalloc_objs() in sh_css.c Message-ID: References: <20260615194548.20963-1-khomenkov@mailbox.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615194548.20963-1-khomenkov@mailbox.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jun 15, 2026 at 10:45:48PM +0300, Andrei Khomenkov wrote: > Replace arithmetic in the kmalloc() function with the kmalloc_objs() > macro, as this calculation method is unsafe. ... > Suggested-by: Andy Shevchenko Nope, I haven't suggested the initial idea. ... What about patches that were sent against this driver for the past year? There were at least two patches of the similar changes. Please, check on the prior work and if needed rebased, updated, upstreamed. (If you haven't taken that, it has to be explained why.) https://lore.kernel.org will help you and https://lore.kernel.org/linux-media/?q=s%3Aatomisp+b%3Akmalloc as a rough first step. -- With Best Regards, Andy Shevchenko