From: Dan Carpenter <error27@gmail.com>
To: Serhat Kumral <serhatkumral1@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, lgs201920130244@gmail.com
Subject: Re: [PATCH v2 2/2] staging: rtl8723bs: put logical continuation on previous line
Date: Tue, 23 Jun 2026 13:10:02 +0300 [thread overview]
Message-ID: <ajpbemasSine9w3i@stanley.mountain> (raw)
In-Reply-To: <20260623100535.5752-2-serhatkumral1@gmail.com>
On Tue, Jun 23, 2026 at 01:05:35PM +0300, Serhat Kumral wrote:
> Move the logical operator '&&' to the previous line in os_intfs.c
> to conform to the Linux kernel coding style guidelines.
> This fixes the checkpatch.pl warning:
> CHECK: Logical continuations should be on the previous line
>
> Signed-off-by: Serhat Kumral <serhatkumral1@gmail.com>
> ---
> Changes in v2:
> - Dropped the third patch of the v1 series (msleep to usleep_range conversion)
> based on feedback from Dan Carpenter.
Thanks!
Reviewed-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
prev parent reply other threads:[~2026-06-23 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 10:05 [PATCH v2 1/2] staging: rtl8723bs: remove multiple blank lines Serhat Kumral
2026-06-23 10:05 ` [PATCH v2 2/2] staging: rtl8723bs: put logical continuation on previous line Serhat Kumral
2026-06-23 10:10 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajpbemasSine9w3i@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=serhatkumral1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox