From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Igor Putko <igorpetindev@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] staging: media: atomisp: drop unused platform_support.h inclusions
Date: Wed, 24 Jun 2026 15:03:06 +0300 [thread overview]
Message-ID: <ajvHetrbCwo18_WU@ashevche-desk.local> (raw)
In-Reply-To: <20260618151246.6678-3-igorpetindev@gmail.com>
On Thu, Jun 18, 2026 at 06:12:45PM +0300, Igor Putko wrote:
> Drop the unused inclusions of the platform_support.h header file across
> the driver. The header has become obsolete after replacing the custom
> CSS_ALIGN() macro with standard kernel attributes.
But in the above list there are no users even with the platform_support.h in
place, right? I mean that this patch can be, for example, applied first
without any regression. Correct? If so, make it the first in the series, it
helps a lot to understand the changes in the (currently) first patch.
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Igor Putko <igorpetindev@gmail.com>
> ---
Code wise looks very good to me, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-24 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 12:09 [PATCH] staging: media: atomisp: prefer __aligned over __attribute__((aligned)) Igor Putko
2026-06-18 12:53 ` Andy Shevchenko
2026-06-18 13:04 ` Andy Shevchenko
2026-06-18 15:12 ` [PATCH v2 0/3] staging: media: atomisp: remove dead platform_support.h header Igor Putko
2026-06-18 15:12 ` [PATCH v2 1/3] staging: media: atomisp: replace CSS_ALIGN() with standard __aligned Igor Putko
2026-06-24 12:00 ` Andy Shevchenko
2026-06-18 15:12 ` [PATCH v2 2/3] staging: media: atomisp: drop unused platform_support.h inclusions Igor Putko
2026-06-24 12:03 ` Andy Shevchenko [this message]
2026-06-18 15:12 ` [PATCH v2 3/3] staging: media: atomisp: remove dead platform_support.h header file Igor Putko
2026-06-24 12:05 ` Andy Shevchenko
2026-06-24 12:06 ` [PATCH v2 0/3] staging: media: atomisp: remove dead platform_support.h header Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajvHetrbCwo18_WU@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=igorpetindev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox