Re: [PATCH v3] staging: media: atomisp: refactor pipe graph dump stage formatting

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Sun, Jul 05, 2026 at 04:56:36PM -0700, Neal Patalay wrote:
> On Sun, Jul 5, 2026 at 7:22 AM Andy Shevchenko wrote:

...

> > If for some reason len is > 0 and offset is 0, this will write beyond
> > the boundaries.
> 
> I'll add a check to make sure the offset is greater than 0.

Please, do not remove context when it's related to the discussion.

I don't think it is that simple. One should think of flexibility.
Can we have (potentially) the case mentioned above? Can you first
investigate that? If it's confirmed that len > 0 and offset == 0
is not possible, no need to change the code, just add a comment.

...

> > This will continue writing even if there are more than 3 lines.
> 
> The original code completely removes the third line from the output
> by writing the third line into enable_info3, and then overwriting that
> buffer with everything after the third line. I'll assume the author meant
> to remove all flags after the third line.

It removes the flags that make the 3rd (and last possible) line too long.

-- 
With Best Regards,
Andy Shevchenko