From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ziad Ali <zalshemy9@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
sakari.ailus@linux.intel.com, andy@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: atomisp: fix typo in atomisp_tables.h
Date: Tue, 7 Jul 2026 12:00:23 +0300 [thread overview]
Message-ID: <akzAJ1pN1nyInsbS@ashevche-desk.local> (raw)
In-Reply-To: <20260707074020.12332-1-zalshemy9@gmail.com>
On Tue, Jul 07, 2026 at 10:40:20AM +0300, Ziad Ali wrote:
No. Read, how to describe changes and write commit message.
Also I'm going to NAK patches against single files. Do your homework.
NAK.
...
> -/*Green enhencement image effect table*/
> +/*Green enhancement image effect table*/
Even after the change this has another style mistake. Read and study
documentation to understand what is that.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-07 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 7:40 [PATCH] staging: atomisp: fix typo in atomisp_tables.h Ziad Ali
2026-07-07 9:00 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-07 7:36 Ziad Ali
2026-07-07 9:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akzAJ1pN1nyInsbS@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=zalshemy9@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox