From: Dan Carpenter <error27@gmail.com>
To: William Elder <williamxelder@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: rtl8723bs: remove comparisons to boolean literals
Date: Wed, 15 Jul 2026 10:45:11 +0300 [thread overview]
Message-ID: <alc6hzi8Eb8LLRqx@stanley.mountain> (raw)
In-Reply-To: <20260714210843.72848-1-williamxelder@gmail.com>
On Tue, Jul 14, 2026 at 03:08:43PM -0600, William Elder wrote:
> Remove comparisons to true and false as they are error prone.
> Use the idiomatic C forms instead. Removed a stray blank line
Don't mix "Removed a stray blank line" into unrelated changes.
>
> Signed-off-by: William Elder <williamxelder@gmail.com>
> ---
>
> v4: Per Greg's request, included all patch revisions and moved the
> version notes below the --- line
> v3: Fix inverted logic for ht_option checks
> v2: No changes, resent v1 as a mistake
> v1: Fix redundant boolean comparisons and introduce inverted logic on false conditions and removed a stray blank line
Please work against the latest staging-devel tree.
regards,
dan carpenter
prev parent reply other threads:[~2026-07-15 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 19:05 [PATCH v3] staging: rtl8723bs: remove comparisons to boolean literals William Elder
2026-07-07 9:49 ` Greg Kroah-Hartman
2026-07-14 21:08 ` [PATCH v4] " William Elder
2026-07-15 7:45 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alc6hzi8Eb8LLRqx@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=williamxelder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox