From: Dan Carpenter <error27@gmail.com>
To: Mariano Baragiola <mbaragiola@linux.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: validate monitor transmit frame lengths
Date: Fri, 17 Jul 2026 14:50:15 +0300 [thread overview]
Message-ID: <aloW93Nb_A9JtUfh@stanley.mountain> (raw)
In-Reply-To: <20260715225938.1403192-1-mbaragiola@linux.com>
On Wed, Jul 15, 2026 at 07:59:38PM -0300, Mariano Baragiola wrote:
> rtw_cfg80211_monitor_if_xmit_entry() removes the radiotap header and
> then reads the 802.11 frame control field without checking that a base
> 802.11 header remains.
>
> The data path also pulls the calculated 802.11, QoS and SNAP header
> span before confirming that the skb contains it. A truncated frame can
> therefore cause out-of-bounds reads or leave insufficient data for the
> Ethernet address writes.
>
> Reject frames that do not contain the base 802.11 header and data
> frames that do not contain their complete calculated header span.
>
> Signed-off-by: Mariano Baragiola <mbaragiola@linux.com>
> ---
Looks reasonable. Please add a Fixes tag.
regards,
dan carpenter
next prev parent reply other threads:[~2026-07-17 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 22:59 [PATCH] staging: rtl8723bs: validate monitor transmit frame lengths Mariano Baragiola
2026-07-17 11:50 ` Dan Carpenter [this message]
2026-07-17 13:03 ` [PATCH v2] " Mariano Baragiola
2026-07-17 13:16 ` Greg Kroah-Hartman
2026-07-17 13:24 ` [PATCH v3] " Mariano Baragiola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aloW93Nb_A9JtUfh@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=mbaragiola@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox