From: Julia Lawall <julia.lawall@inria.fr>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operator in HalBtc8723b1Ant.h
Date: Tue, 6 Apr 2021 18:44:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104061843260.16390@hadrien> (raw)
In-Reply-To: <20210406164001.13646-1-fmdefrancesco@gmail.com>
On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected
> by checkpatch.pl. Spaces are preferred to improve readibility.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h
> index 59e8c68cdc20..719e19420a3b 100644
> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h
> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h
> @@ -15,7 +15,7 @@
> #define BT_INFO_8723B_1ANT_B_CONNECTION BIT0
>
> #define BT_INFO_8723B_1ANT_A2DP_BASIC_RATE(_BT_INFO_EXT_) \
> - (((_BT_INFO_EXT_&BIT0)) ? true : false)
> + (((_BT_INFO_EXT_ & BIT0)) ? true : false)
There seem to be a lot of parentheses in this code (( )). Maybe you can
make a series and fix that problem too.
julia
>
> #define BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT 2
>
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210406164001.13646-1-fmdefrancesco%40gmail.com.
>
next prev parent reply other threads:[~2021-04-06 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 16:40 [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operator in HalBtc8723b1Ant.h Fabio M. De Francesco
2021-04-06 16:44 ` Julia Lawall [this message]
2021-04-06 16:53 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104061843260.16390@hadrien \
--to=julia.lawall@inria.fr \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox