From: Julia Lawall <julia.lawall@inria.fr>
To: Karolina Drobnik <karolinadrobnik@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
forest@alittletooquiet.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: vt6655: Fix line wrapping in rf.c file
Date: Mon, 18 Oct 2021 17:10:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2110181708110.3174@hadrien> (raw)
In-Reply-To: <20211018150526.9718-1-karolinadrobnik@gmail.com>
On Mon, 18 Oct 2021, Karolina Drobnik wrote:
> Fix line length warnings raised by checkpatch.pl in
> rf.c file for `RFvWriteWakeProgSyn`,`RFbRawSetPower`
> and `RFbAL7230SelectChannelPostProcess`functions.
>
> Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
> ---
> drivers/staging/vt6655/rf.c | 66 +++++++++++++++++++++++++++----------
> 1 file changed, 49 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index a6f17162d017..206d34b555bc 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -699,11 +699,17 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
> return false;
>
> for (ii = 0; ii < CB_AL2230_INIT_SEQ; ii++)
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL2230InitTable[ii]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii),
> + dwAL2230InitTable[ii]);
>
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL2230ChannelTable0[uChannel - 1]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii),
> + dwAL2230ChannelTable0[uChannel - 1]);
> ii++;
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL2230ChannelTable1[uChannel - 1]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii),
> + dwAL2230ChannelTable1[uChannel - 1]);
> break;
>
> /* Need to check, PLLON need to be low for channel setting */
> @@ -716,17 +722,28 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
>
> if (uChannel <= CB_MAX_CHANNEL_24G) {
> for (ii = 0; ii < CB_AL7230_INIT_SEQ; ii++)
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL7230InitTable[ii]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX
> + + ii), dwAL7230InitTable[ii]);
The placement of + ii) is not a good solution. Can it be moved up to the
line before? Likewise in the next case.
> } else {
> for (ii = 0; ii < CB_AL7230_INIT_SEQ; ii++)
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL7230InitTableAMode[ii]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX
> + + ii),
> + dwAL7230InitTableAMode[ii]);
> }
>
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL7230ChannelTable0[uChannel - 1]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii),
> + dwAL7230ChannelTable0[uChannel - 1]);
> ii++;
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL7230ChannelTable1[uChannel - 1]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii),
> + dwAL7230ChannelTable1[uChannel - 1]);
> ii++;
> - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL7230ChannelTable2[uChannel - 1]);
> + MACvSetMISCFifo(priv,
> + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii),
> + dwAL7230ChannelTable2[uChannel - 1]);
> break;
>
> case RF_NOTHING:
> @@ -736,7 +753,8 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
> return false;
> }
>
> - MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, (unsigned long)MAKEWORD(bySleepCount, byInitCount));
> + MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX,
> + (unsigned long)MAKEWORD(bySleepCount, byInitCount));
>
> return true;
> }
> @@ -836,20 +854,32 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
> case RF_AIROHA:
> ret &= IFRFbWriteEmbedded(priv, dwAL2230PowerTable[byPwr]);
> if (rate <= RATE_11M)
> - ret &= IFRFbWriteEmbedded(priv, 0x0001B400 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
> + ret &= IFRFbWriteEmbedded(priv, 0x0001B400
> + + (BY_AL2230_REG_LEN << 3)
> + + IFREGCTL_REGW);
Also not great. Maybe there could be a newline before the 0x0001B400 too.
julia
> else
> - ret &= IFRFbWriteEmbedded(priv, 0x0005A400 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
> + ret &= IFRFbWriteEmbedded(priv, 0x0005A400
> + + (BY_AL2230_REG_LEN << 3)
> + + IFREGCTL_REGW);
>
> break;
>
> case RF_AL2230S:
> ret &= IFRFbWriteEmbedded(priv, dwAL2230PowerTable[byPwr]);
> if (rate <= RATE_11M) {
> - ret &= IFRFbWriteEmbedded(priv, 0x040C1400 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
> - ret &= IFRFbWriteEmbedded(priv, 0x00299B00 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
> + ret &= IFRFbWriteEmbedded(priv, 0x040C1400
> + + (BY_AL2230_REG_LEN << 3)
> + + IFREGCTL_REGW);
> + ret &= IFRFbWriteEmbedded(priv, 0x00299B00
> + + (BY_AL2230_REG_LEN << 3)
> + + IFREGCTL_REGW);
> } else {
> - ret &= IFRFbWriteEmbedded(priv, 0x0005A400 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
> - ret &= IFRFbWriteEmbedded(priv, 0x00099B00 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
> + ret &= IFRFbWriteEmbedded(priv, 0x0005A400
> + + (BY_AL2230_REG_LEN << 3)
> + + IFREGCTL_REGW);
> + ret &= IFRFbWriteEmbedded(priv, 0x00099B00
> + + (BY_AL2230_REG_LEN << 3)
> + + IFREGCTL_REGW);
> }
>
> break;
> @@ -921,7 +951,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
> * register
> * Channel Index 1~14
> */
> - if ((byOldChannel <= CB_MAX_CHANNEL_24G) && (byNewChannel > CB_MAX_CHANNEL_24G)) {
> + if ((byOldChannel <= CB_MAX_CHANNEL_24G) &&
> + (byNewChannel > CB_MAX_CHANNEL_24G)) {
> /* Change from 2.4G to 5G [Reg] */
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[2]);
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[3]);
> @@ -930,7 +961,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[10]);
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[12]);
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[15]);
> - } else if ((byOldChannel > CB_MAX_CHANNEL_24G) && (byNewChannel <= CB_MAX_CHANNEL_24G)) {
> + } else if ((byOldChannel > CB_MAX_CHANNEL_24G) &&
> + (byNewChannel <= CB_MAX_CHANNEL_24G)) {
> /* Change from 5G to 2.4G [Reg] */
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[2]);
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[3]);
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20211018150526.9718-1-karolinadrobnik%40gmail.com.
>
next prev parent reply other threads:[~2021-10-18 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 15:05 [PATCH] staging: vt6655: Fix line wrapping in rf.c file Karolina Drobnik
2021-10-18 15:10 ` Julia Lawall [this message]
2021-10-18 15:12 ` Greg KH
2021-10-19 5:56 ` Joe Perches
2021-10-19 10:59 ` Karolina Drobnik
2021-10-19 11:12 ` Greg KH
2021-10-19 12:26 ` Joe Perches
2021-10-19 13:12 ` [Outreachy kernel] " Fabio M. De Francesco
2021-10-19 13:07 ` Fabio M. De Francesco
2021-10-19 15:08 ` Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2110181708110.3174@hadrien \
--to=julia.lawall@inria.fr \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox