Re: [Outreachy kernel] [PATCH] staging: vt6655: Rename `by_preamble_type` parameter

Julia Lawall
2021-10-20T08:54:29Z

On Wed, 20 Oct 2021, Karolina Drobnik wrote:

> Drop `by` prefix in the first parameter of `bb_get_frame_time` function.
> As the original argument, `byPreambleType`, was renamed to `preamble_type`,
> the parameter referring to it is now renamed to match the new naming
> convention.
> Update `bb_get_frame_time` comment to reflect that change.
>
> This patch is a follow-up work to this commit:
> Commit 548b6d7ebfa4 ("staging: vt6655: Rename byPreambleType field")

This is not going to be practical. If the previous patch is accepted,
then this it not needed. If the previous patch is not yet accepted, then
there needs to be a vn+1 putting the patches together into a series.

> Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
> ---
> drivers/staging/vt6655/baseband.c | 6 +++---
> drivers/staging/vt6655/baseband.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 5efca92f1f18..8f9177db6663 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -1691,7 +1691,7 @@ static const unsigned short awc_frame_time[MAX_RATE] = {
> *
> * Parameters:
> * In:
> - * by_preamble_type - Preamble Type
> + * preamble_type - Preamble Type
> * by_pkt_type - PK_TYPE_11A, PK_TYPE_11B, PK_TYPE_11GB, PK_TYPE_11GA

In the realm of small cleanups to this driver, the extra space in front of
the - above is a bit annoying.

> * cb_frame_length - Baseband Type
> * tx_rate - Tx Rate
> @@ -1700,7 +1700,7 @@ static const unsigned short awc_frame_time[MAX_RATE] = {
> * Return Value: FrameTime
> *
> */
> -unsigned int bb_get_frame_time(unsigned char by_preamble_type,
> +unsigned int bb_get_frame_time(unsigned char preamble_type,
> unsigned char by_pkt_type,
> unsigned int cb_frame_length,
> unsigned short tx_rate)
> @@ -1717,7 +1717,7 @@ unsigned int bb_get_frame_time(unsigned char by_preamble_type,
> rate = (unsigned int)awc_frame_time[rate_idx];
>
> if (rate_idx <= 3) { /* CCK mode */
> - if (by_preamble_type == 1) /* Short */
> + if (preamble_type == 1) /* Short */

I hope you will get around to replacing the 1 by the appropriate constant
and removing the "Short" comment.

julia

> preamble = 96;
> else
> preamble = 192;
> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> index 0a30afaa7cc3..15b2802ed727 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -44,7 +44,7 @@
> #define TOP_RATE_2M 0x00200000
> #define TOP_RATE_1M 0x00100000
>
> -unsigned int bb_get_frame_time(unsigned char by_preamble_type,
> +unsigned int bb_get_frame_time(unsigned char preamble_type,
> unsigned char by_pkt_type,
> unsigned int cb_frame_length,
> unsigned short w_rate);
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20211020084033.414994-1-karolinadrobnik%40gmail.com.
>