From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631CE33E0; Wed, 6 Apr 2022 15:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=jzSTEJQcGfGZ7JxkMk9H1mBl0JJZpFa9fo6uzqvky2Q=; b=sGIk5oEDLdgRxABX5JIFjj+a2Kwz7ZcKwYfWPfcBi5oloLW25ieCgVX/ iZY2U4Tiz6RogGzLu2VXuXumoCAbtyqXBs8t6/aRFgKMPg6hWiQ+j5wF8 0Qfe7ljgfV39td61LZ7Ny1ypPWU0gjUPh0ww4ZnvjbDemrUPJFdQcKLOj E=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.90,240,1643670000"; d="scan'208";a="30395387" Received: from unknown (HELO hadrien) ([95.128.147.62]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 17:37:48 +0200 Date: Wed, 6 Apr 2022 17:37:43 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: Alaa Mohamed cc: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8712: remove Unnecessary parentheses In-Reply-To: <20220406152858.14076-1-eng.alaamohamedsoliman.am@gmail.com> Message-ID: References: <20220406152858.14076-1-eng.alaamohamedsoliman.am@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII If you want to capitalize something in the subject, it could be the first word. Capitalizing the second word is a bit strange. On Wed, 6 Apr 2022, Alaa Mohamed wrote: > Reported by checkpatch: > > CHECK: Unnecessary parentheses Indicating that the problem was detected by checkpatch is good. But actually, the parentheses all have the same property. So you could use the log message to describe what kind of unnecessary parentheses were removed. That would help the maintainer know what to look for. julia > Signed-off-by: Alaa Mohamed > --- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > index 3b6926613257..6c692ad7bde7 100644 > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > @@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta, > (param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len)); > if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */ > memcpy(psta->tkiptxmickey. skey, > - &(param->u.crypt.key[16]), 8); > + ¶m->u.crypt.key[16], 8); > memcpy(psta->tkiprxmickey. skey, > - &(param->u.crypt.key[24]), 8); > + ¶m->u.crypt.key[24], 8); > padapter->securitypriv. busetkipkey = false; > mod_timer(&padapter->securitypriv.tkip_timer, > jiffies + msecs_to_jiffies(50)); > @@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev, > u32 ht_ielen = 0; > char *p; > u8 ht_cap = false; > - struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); > + struct mlme_priv *pmlmepriv = &padapter->mlmepriv; > struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network; > u8 *prates; > > @@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev, > } > plist = plist->next; > } > - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL); > + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL); > if (pdata->length >= 34) { > if (copy_to_user((u8 __user *)pdata->pointer + 32, > (u8 *)&pdata->flags, 1)) > -- > 2.35.1 > > >