From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7212570; Thu, 7 Apr 2022 17:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=q7lEK63sLrZyFdOoNnVucyuJ6DHz13VXShb3q/vADrc=; b=ihpfJ0qywUrTSNMp3kCT0gGxNem/uv26NSUDcFDGiT40B9oyI4ZdVmCc 6/UNMdCW4k58xgViscOrDNDc9cxgQkzN96y7bl0TwUUjhWXhvtDGXqNPD AyqTy/6KminBvrYy3HqMoUnnPa7RyTpoYt13ul+4OBL5tBHOUC3cwhpa1 8=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.90,242,1643670000"; d="scan'208";a="30649903" Received: from unknown (HELO hadrien) ([95.128.147.62]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 19:58:34 +0200 Date: Thu, 7 Apr 2022 19:58:33 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: MAHAK GUPTA cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie In-Reply-To: Message-ID: References: <20220407120945.31030-1-mahak_g@cs.iitr.ac.in> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 7 Apr 2022, MAHAK GUPTA wrote: > On Thu, Apr 7, 2022 at 5:44 PM Julia Lawall wrote: > > > > > > > > On Thu, 7 Apr 2022, Mahak Gupta wrote: > > > > > Adhere to linux kernel coding style. > > > > > > Reported by checkpatch: > > > > > > CHECK: Avoid CamelCase: > > > > As another patch, you could also adjust the structure field name. > > > > julia > > > > > > > > Signed-off-by: Mahak Gupta > > > --- > > > drivers/staging/rtl8712/ieee80211.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c > > > index f926809b1021..7d8f1a29d18a 100644 > > > --- a/drivers/staging/rtl8712/ieee80211.c > > > +++ b/drivers/staging/rtl8712/ieee80211.c > > > @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv) > > > uint sz = 0; > > > struct wlan_bssid_ex *dev_network = ®istrypriv->dev_network; > > > u8 *ie = dev_network->IEs; > > > - u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod; > > > + u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod; > > > > > > /*timestamp will be inserted by hardware*/ > > > sz += 8; > > > ie += sz; > > > /*beacon interval : 2bytes*/ > > > - *(__le16 *)ie = cpu_to_le16(beaconPeriod); > > > + *(__le16 *)ie = cpu_to_le16(beacon_period); > > > sz += 2; > > > ie += 2; > > > /*capability info*/ > > > -- > > > 2.17.1 > > > > > > > > > > > Sure, on it. Thanks. It's good not to top post, but you can put your response right under the text you are responding to. julia