Re: [PATCH v2] staging: rtl8712: efuse: code style - avoid macro argument precedence issues

[Julia Lawall <julia.lawall@inria.fr>]

On Tue, 12 Apr 2022, aliya-rahmani wrote:

> From: Aliya Rahmani <aliyarahmani786@gmail.com>
>
> This patch fixes checkpatch warnings of precedence issues. Added parentheses
> around macro arguments 'offset' and 'word_en'.
>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
> ---
> v1 -> v2: Updated the description of the fixes.

You have a lot of messages labeled v2 now.  This will be confusing for
Greg.  Make a v3 that is entirely correct.

julia

> ---
>
>  drivers/staging/rtl8712/rtl8712_efuse.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.h b/drivers/staging/rtl8712/rtl8712_efuse.h
> index 4969d307e978..2e1ea9d7a295 100644
> --- a/drivers/staging/rtl8712/rtl8712_efuse.h
> +++ b/drivers/staging/rtl8712/rtl8712_efuse.h
> @@ -15,8 +15,8 @@
>
>  #define GET_EFUSE_OFFSET(header)	((header & 0xF0) >> 4)
>  #define GET_EFUSE_WORD_EN(header)	(header & 0x0F)
> -#define MAKE_EFUSE_HEADER(offset, word_en)	(((offset & 0x0F) << 4) | \
> -						(word_en & 0x0F))
> +#define MAKE_EFUSE_HEADER(offset, word_en)	((((offset) & 0x0F) << 4) | \
> +						((word_en) & 0x0F))
>  /*--------------------------------------------------------------------------*/
>  struct PGPKT_STRUCT {
>  	u8 offset;
> --
> 2.25.1
>
>
>