From: Julia Lawall <julia.lawall@inria.fr>
To: Aliya Rahmani <aliyarahmani786@gmail.com>
Cc: florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8712: cmd:remove redundant space after cast
Date: Wed, 13 Apr 2022 12:25:46 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2204131225230.3091@hadrien> (raw)
In-Reply-To: <20220413102356.25357-1-aliyarahmani786@gmail.com>
Going for maximally picky, there should be a space after cmd:
julia
On Wed, 13 Apr 2022, Aliya Rahmani wrote:
> Remove the unnecessary space immediately after a cast. Identified by
> checkpatch: CHECK: No space is necessary after a cast.
>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
> index f5746020a1b7..4be96df5a329 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> @@ -536,7 +536,7 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
> return;
> }
> init_h2fwcmd_w_parm_no_rsp(ph2c, psetstakey_para, _SetStaKey_CMD_);
> - ph2c->rsp = (u8 *) psetstakey_rsp;
> + ph2c->rsp = (u8 *)psetstakey_rsp;
> ph2c->rspsz = sizeof(struct set_stakey_rsp);
> ether_addr_copy(psetstakey_para->addr, sta->hwaddr);
> if (check_fwstate(pmlmepriv, WIFI_STATION_STATE))
> --
> 2.25.1
>
>
>
prev parent reply other threads:[~2022-04-13 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 10:23 [PATCH] staging: rtl8712: cmd:remove redundant space after cast Aliya Rahmani
2022-04-13 10:25 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2204131225230.3091@hadrien \
--to=julia.lawall@inria.fr \
--cc=aliyarahmani786@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox